Skip to content

Conversation

@DavidSpickett
Copy link
Collaborator

...and add shared libs as a suggestion.

  • Mark options, option values and program names as plain text.
  • Add a blank line between the option and the explanatory text
    so that it doesn't get printed on the same line.
    (this seems to be the original intent of the rst source anyway)
  • Update the phrasing of a couple of the options.
  • Add BUILD_SHARED_LIBS to suggestions.

I realised this existed after answering
https://discourse.llvm.org/t/clang-development-environment/81140.

* Mark options, option values and program names as plain text.
* Add a blank line between the option and the explanatory text
  so that it doesn't get printed on the same line.
  (this seems to be the original intent of the rst source anyway)
* Update the phrasing of a couple of the options.
@DavidSpickett DavidSpickett requested a review from tru September 13, 2024 09:30
@DavidSpickett
Copy link
Collaborator Author

DavidSpickett commented Sep 13, 2024

With the added spacing it renders them like:

  • -G Ninja

    Setting this option will allow you to build with ninja instead of make. Building with ninja significantly improves your build time, especially with incremental builds, and improves your memory usage.

@DavidSpickett DavidSpickett changed the title [llvm][Docs] Improve the formatting of the Common Problems section [llvm][docs] Improve the formatting of the Common Problems section Sep 13, 2024
@DavidSpickett
Copy link
Collaborator Author

ping!

1 similar comment
@DavidSpickett
Copy link
Collaborator Author

ping!

@DavidSpickett DavidSpickett merged commit 6b4c4d7 into llvm:main Oct 8, 2024
10 checks passed
@DavidSpickett DavidSpickett deleted the llvm-doc branch October 8, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants